Update runners to expect a message #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the runners to expect to be passed a generic message. This is part of making events a kind of message and siblings to job. For `Runner` and `QsRunner` this only involved renaming job to message for the runners and handlers. No other functionality was changed. For the test runners, this adds a `TestRunner` for the common logic between `JobTestRunner` and `EventTestRunner` and changes `EventTestRunner` to inherit from it. This makes the test runners siblings which is how jobs and events will eventually be. This allows them to make use of the common logic for running an handler in the test suite but also do custom logic as needed.
|
@jcredding yeah, breaking it up like this is good in that it is smaller and easier to digest on its own, but bad in that I feel like I'm missing the "big picture" on the goal of making Events subclass Message. This change in and of itself if fine - I'm longing for that big picture diff though. Anyway, just bitching 👎 |
jcredding
added a commit
that referenced
this pull request
Jun 2, 2015
Update runners to expect a message
jcredding
added a commit
that referenced
this pull request
Aug 4, 2015
* Add `Event` (#67) * Add `EventHandler` mixin (#68) * Hotfix: Updating benchmark report to set new baseline (a3a88f5) * Add `dispatcher_queue` to Qs, setup for publishing events (#69) * Add payload type to jobs (#70) * Update `Event` to set a custom payload type (#73) * Add `Qs.publish` (#74) * Add `event` to `Queue` (#75) * Split `TestHelpers` (#72) * Store queues as event subscribers in redis (#76) * Add `Payload` module for serializing and deserializing (#78) * Add `Message`, setup `Event` being a kind of `Message` (#79) * Add `MessageHandler` (#80) * Update runners to expect a message (#81) * Update `Event` to be a kind of `Message` (#82) * Add optional publisher for events (#77) * Rename `RedisItem` to `QueueItem` (#83) * Pass params via options when building jobs and events (#84) * Add separate logging for jobs and events (#85) * Add `DispatchJobHandler` (#86) * Update dispatcher queue (#87) * Benchmark publishing and running events (#89) * Add daemon event handling system tests (#88) * Add subscription system tests, fix sync (#90) /cc @kellyredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the runners to expect to be passed a generic message.
This is part of making events a kind of message and siblings to
job.
For
RunnerandQsRunnerthis only involved renaming job tomessage for the runners and handlers. No other functionality was
changed.
For the test runners, this adds a
TestRunnerfor the commonlogic between
JobTestRunnerandEventTestRunnerand changesEventTestRunnerto inherit from it. This makes the test runnerssiblings which is how jobs and events will eventually be. This
allows them to make use of the common logic for running an handler
in the test suite but also do custom logic as needed.
@kellyredding - Ready for review.