move process label configuration into the daemon #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with the process *id* configuration already being in the daemon. This also has the benefit of keeping all non-internal configuration handling being done via the daemon. The daemon data object that is passed around now is aware of the process label. This option is a little different from the others as it isn't intended to be driven via a DSL option and also that it can instead be driven by an ENV var. The process label attr behaves just as it did before: it still defaults to the daemon `name`, it can be specified using the same `QS_PROCESS_LABEL` env var, and it is still applied to the process name as before. The goal here is to make the process label value available to the error handler in a standard way (via the daemon data) just like all other user-driven configuration values.
|
@kellyredding - Good stuff 💥 This is what I would expect and is basically what I did to Sanford. |
kellyredding
added a commit
that referenced
this pull request
Sep 8, 2015
move process label configuration into the daemon
kellyredding
added a commit
that referenced
this pull request
Sep 8, 2015
* move process label configuration into the daemon #92 * hotfix: use more efficient method for checking the QS_PROCESS_LABEL env var (c066219) * expose dat-worker-pool worker callback configuration #93 /cc @jcredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more consistent with the process id configuration already
being in the daemon. This also has the benefit of keeping all
non-internal configuration handling being done via the daemon. The
daemon data object that is passed around now is aware of the process
label.
This option is a little different from the others as it isn't
intended to be driven via a DSL option and also that it can instead
be driven by an ENV var.
The process label attr behaves just as it did before: it still
defaults to the daemon
name, it can be specified using the sameQS_PROCESS_LABELenv var, and it is still applied to the processname as before.
The goal here is to make the process label value available to the
error handler in a standard way (via the daemon data) just like all
other user-driven configuration values.
@jcredding how does this look? Is it what you would expect? ready for review.