Identify and skip unrenderable snoomark syntaxes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏃 unfortunately I'm not going to have time to review this before being out of town this week. Please feel free to re-eyeglass me if it's still open next week; otherwise, there are definitely people in #infra that can review C in addition to Jordan's astute eyes. |
|
Per discussion with @wangwh03, let's not focus on this since we've nearly ramped to 100% redesign enrollment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👓 @spladug @JordanMilne
Per JIRA CREATE-518:
The new rich-text editor enables two additional inline styles: underline and subscript. We've extended our CommonMark parser with the following corresponding syntaxes:
~underline~%(subscript)%subscript%subscriptsnudown does not provide for either of the two styles. Therefore, in order to preserve compatibility of new content with old clients, we should strip these styles when rendering via snudown.
This PR is mostly copy/paste of existing functionality. It passes the additional tests against the new syntaxes.
Note: in the case of underline, we can alternatively wrap content in
<u>tags. I haven't elected to do that here as I'm not sure whether we want to begin rendering out a style we've never supported historically, but it's certainly something that can be added very easily.