Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible fix for source-maps issues #746

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Possible fix for source-maps issues #746

merged 2 commits into from
Nov 10, 2016

Conversation

erdillon
Copy link
Contributor

Based on webpack/webpack#2145 this seems to fix source-maps issues.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gigabo
Copy link
Contributor

gigabo commented Nov 10, 2016

Hi @erdillon thanks for tackling this!

Looks like the build is failing on _webpack2 being undefined...

/home/travis/build/redfin/react-server/packages/react-server-cli/src/compileClient.js
  225:34  error  '_webpack2' is not defined  no-undef
✖ 1 problem (1 error, 0 warnings)

@gigabo gigabo added the bug An issue with the system label Nov 10, 2016
@gigabo
Copy link
Contributor

gigabo commented Nov 10, 2016

Nice! Thanks @erdillon!

@gigabo gigabo merged commit 3c2d173 into redfin:master Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erdillon @CLAassistant @gigabo