Add Redux Support #839
Add Redux Support #839
Conversation
| @@ -0,0 +1,60 @@ | |||
| const Q = require('q'); | |||
There was a problem hiding this comment.
prefer native promises -- no need to take a dep
| const state = this.store.getState(); | ||
| const stateKeys = Object.keys(this.stateWaitMap); | ||
|
|
||
| for (let i = 0; i < stateKeys.length; i++) { |
There was a problem hiding this comment.
Maybe it would be easier to read if you used a forEach?
Object.keys(this.stateWaitMap).forEach(stateKey => {
if (stateKey.promise.isPending()) {
| when(stateProps) { | ||
| const promises = stateProps.map((stateProp) => { | ||
| if (!this.stateWaitMap.hasOwnProperty(stateProp)) { | ||
| this.stateWaitMap[stateProp] = Q.defer(); |
| this.checkStateStatus(); | ||
| const unsub = this.store.subscribe(this.checkStateStatus.bind(this)); | ||
|
|
||
| return Q.all(promises).then(() => { |
|
|
||
| class RootProvider extends React.Component { | ||
| render() { | ||
| if (!this.props.store) throw("Error Root Provider expects a store passed in as a prop"); |
There was a problem hiding this comment.
nit: include the braces here
| } | ||
|
|
||
| RootProvider.isRootProvider = function(element) { | ||
| return element && element.props && element.props._isRootProvider; |
There was a problem hiding this comment.
prefer a symbol for this, e.g.
const rootProviderSymbol = Symbol();
class RootProvider extends React.Component {
[rootProviderSymbol]: true,
static isRootProvider(elem) {
return elem[rootProviderSymbol];
}
}
| "description": "Package to support Redux in React-Server", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 0" |
| @@ -0,0 +1,76 @@ | |||
| import {createStore, applyMiddleware} from "redux"; // eslint-disable-line | |||
There was a problem hiding this comment.
why disable the linter for all these?
| "url": "https://github.com/redfin/react-server" | ||
| }, | ||
| "keywords": [ | ||
| "redux" |
There was a problem hiding this comment.
maybe toss a react server mention in there?
| { | ||
| "name": "react-server-redux", | ||
| "version": "0.5.1", | ||
| "description": "Package to support Redux in React-Server", |
There was a problem hiding this comment.
I think it might be self-evident its a package, so maybe just "Redux support for React Server"?
|
Could you also update the redux example? The test-pages are a great start, but I'd like a "minimal example" so I can think about the api. |
sresant
force-pushed
the
st-redux-support
branch
from
cb0257b
to
12cee72
Compare
This pr relates to #788... adding support for redux.
The package provides a RootProvider which can be used to wrap your RootElement components with a single RootProvider rather then a provider for each RootElement. Additionally a ReduxAdapter(Can this be a better name?) class which provides developers the ability to wait for specific values to be available in the state tree. I have also included two test pages to showcase each usage.
Let me know what you think and how I can improve it!