-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Frameback #880
Drop Frameback #880
Conversation
@@ -131,8 +105,6 @@ export default class NavigationPlaygroundPage { | |||
<li>CT: Client Transition</li> | |||
<li>RD: Reuse DOM</li> | |||
<li>BD: Bundle Data</li> | |||
<li>FB: Frameback</li> | |||
<li><span className='not-available'>FB</span>: Frameback disabled (already in a frame)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some styling (strikethrough, I think) associated with the not-available
class that can be removed from the CSS, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I ll check that out!
This is awesome @szhou8813! It makes the history navigation stack management so much simpler! I think there's probably some documentation that will need to be tweaked, too. |
Oh I guess we ll need to update tutorials/docs on react-server.io too. How do I do that? |
The content on react-server.io is queried from GitHub. If you update the appropriate docs in the repository it will be reflected on the site within one minute of merging to master. |
65e0d7a
to
b0cef8b
Compare
Awesome! Thanks for dealing with this @szhou8813! |
Added |
No one uses frameback, so we're dropping it.