Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Frameback #880

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Drop Frameback #880

merged 1 commit into from
Mar 1, 2017

Conversation

szhou8813
Copy link
Contributor

No one uses frameback, so we're dropping it.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2017

CLA assistant check
All committers have signed the CLA.

@@ -131,8 +105,6 @@ export default class NavigationPlaygroundPage {
<li>CT: Client Transition</li>
<li>RD: Reuse DOM</li>
<li>BD: Bundle Data</li>
<li>FB: Frameback</li>
<li><span className='not-available'>FB</span>: Frameback disabled (already in a frame)</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some styling (strikethrough, I think) associated with the not-available class that can be removed from the CSS, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I ll check that out!

@gigabo
Copy link
Contributor

gigabo commented Feb 13, 2017

This is awesome @szhou8813! It makes the history navigation stack management so much simpler!

I think there's probably some documentation that will need to be tweaked, too.

@szhou8813
Copy link
Contributor Author

Oh I guess we ll need to update tutorials/docs on react-server.io too. How do I do that?

@davidalber
Copy link
Contributor

The content on react-server.io is queried from GitHub. If you update the appropriate docs in the repository it will be reflected on the site within one minute of merging to master.

@gigabo
Copy link
Contributor

gigabo commented Feb 14, 2017

Awesome! Thanks for dealing with this @szhou8813!

@gigabo gigabo added the cleanup label Feb 14, 2017
@roblg
Copy link
Member

roblg commented Feb 28, 2017

Added breaking-change. I believe it's probably unused, but you never know ;)

@gigabo gigabo merged commit ca3e74c into redfin:master Mar 1, 2017
@gigabo gigabo changed the title Issue #775 Drop Frameback Drop Frameback Mar 9, 2017
@gigabo gigabo mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants