-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic installation of Automation Hub #30
Conversation
the basic configuration works, using the database deployed by the Tower installer, a more complex configuration with standalone/external database should be possible, but not tested. I took also the chance to rename 'tower_database' to 'tower_database_host' which is clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
Could you add the new vars to the relevant READMEs please
Addressed the documentation topic, but I left the firewall topic open for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me now
Once the Readme choice is solved this is solid to good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed this again looks good.
What does this PR do?
the basic configuration works, using the database deployed by the Tower installer, and self-signed certificates;
a more complex configuration with standalone/external database should be possible, but not tested. I didn't even look at the SSL configuration aspects.
I took also the chance to rename 'tower_database' to 'tower_database_host' which is clearer.
How should this be tested?
Add the
tower_ah_...
variables to your inventory and re-run the setup.Is there a relevant Issue open for this?
n/a
Other Relevant info, PRs, etc.
The installation fails when installing a single node Tower with embedded database, and with the AH using the embedded database, because the setup playbooks don't open the firewall. I only added a commented out potential fix, subject to discussion (because @sean-m-sullivan said he needs the role to work without admin rights).