Add JMESPath filtering feature #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change, if applied, adds a new argument to the agnosticv CLI: ``` --has STRING ``` That option allows the user to filter the output of `--list` by specifying a JSMEPath expression. The expression is applied on the result of the merge for each catalog item and the catalog item is included if the expression matches (result is not null and not false). That feature will be used later in agnosticv-operator. Examples: ``` $ agnosticv --list --has "master_instance_type == 'c5d.xlarge'" gpte/OCP4_GETTING_STARTED_WORKSHOP/dev.yaml gpte/OCP4_GETTING_STARTED_WORKSHOP/prod.yaml gpte/OCP4_GETTING_STARTED_WORKSHOP/test.yaml gpte/OCP4_WORKSHOP_PIPELINES/dev.yaml gpte/OCP4_WORKSHOP_PIPELINES/prod.yaml ``` ``` $ agnosticv --list --has "env_type == 'ocp4-cluster'" |wc -l 189 $ grep ocp4-cluster * -r|wc -l 78 # NOT the same because env_type is usually defined in common.yml ```
jkupferer
approved these changes
Feb 9, 2021
fridim
added a commit
that referenced
this pull request
Feb 16, 2021
This change, if applied, adds a new argument to the agnosticv CLI: ``` --has STRING ``` That option allows the user to filter the output of `--list` by specifying a JSMEPath expression. The expression is applied on the result of the merge for each catalog item and the catalog item is included if the expression matches (result is not null and not false). That feature will be used later in agnosticv-operator. Examples: ``` $ agnosticv --list --has "master_instance_type == 'c5d.xlarge'" gpte/OCP4_GETTING_STARTED_WORKSHOP/dev.yaml gpte/OCP4_GETTING_STARTED_WORKSHOP/prod.yaml gpte/OCP4_GETTING_STARTED_WORKSHOP/test.yaml gpte/OCP4_WORKSHOP_PIPELINES/dev.yaml gpte/OCP4_WORKSHOP_PIPELINES/prod.yaml ``` ``` $ agnosticv --list --has "env_type == 'ocp4-cluster'" |wc -l 189 $ grep ocp4-cluster * -r|wc -l 78 # NOT the same because env_type is usually defined in common.yml ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, if applied, adds a new argument to the agnosticv CLI:
That option allows the user to filter the output of
--listbyspecifying a JSMEPath expression. The expression is applied on the
result of the merge for each catalog item and the catalog item is
included if the expression matches (result is not null and not false).
That feature will be used later in agnosticv-operator.
Examples: