Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #30 modify basic ArgoCD route from boolean to Object #31

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fix for Issue #30 modify basic ArgoCD route from boolean to Object #31

merged 1 commit into from
Sep 11, 2020

Conversation

AlyIbrahim
Copy link
Contributor

@AlyIbrahim AlyIbrahim commented Sep 11, 2020 •
edited
Loading

Description in Issue #30
I guess we should also add route to the basic-example yaml file, let me know and I can add it to the same PR

sabre1041
sabre1041 approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for updating the API spec changes in the operator

@sabre1041 sabre1041 merged commit d1b8868 into redhat-cop:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlyIbrahim @sabre1041