Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for ansible validated content #41

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

r0x0d
Copy link
Collaborator

@r0x0d r0x0d commented Apr 15, 2024

Updated one of the project dependencies to use redhat.rhel_system_roles instead of fedora system roles.

Moved the CODEOWNERS file to the root of the project instead of under .github folder.

Relates to: ansible/validated-content-discussion#27 (comment)

@r0x0d r0x0d requested review from djdanielsson and andywaltlova and removed request for andywaltlova and djdanielsson April 15, 2024 17:19
@r0x0d r0x0d force-pushed the fixes-for-validated-content branch 13 times, most recently from 64c4d90 to 4b17a4e Compare April 16, 2024 18:00
Copy link
Collaborator

@andywaltlova andywaltlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay, but what do we do about the CI checks? With rhel system roles it will be hard to get it working, also one of the integration tests seems to use unsupported python version devel with 3.7.

@r0x0d r0x0d force-pushed the fixes-for-validated-content branch from 4b17a4e to 372a658 Compare April 17, 2024 13:12
Updated one of the project dependencies to use redhat.rhel_system_roles
instead of fedora system roles.

Moved the CODEOWNERS file to the root of the project instead of under
.github folder.
@r0x0d r0x0d force-pushed the fixes-for-validated-content branch from 372a658 to 6971a8d Compare April 17, 2024 13:14
@andywaltlova andywaltlova merged commit c462754 into redhat-cop:main Apr 17, 2024
21 checks passed
@r0x0d r0x0d deleted the fixes-for-validated-content branch April 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants