[RHDX-131][RHDX-237] Add CSS and JS sourcemaps & remove Hugo from rhdp2 #3486
Conversation
This adds CSS and JS sourcemaps to our rhdp2/rhd-frontend assets/build process. This required removing some build logic that was moving dist files around in Dockerfile.mp and dev/build-rhdp2-theme.sh, updating paths across various FE build and config files and of course adding to the existing node-sass command(s) in package.json to include the building of sourcemaps.
jordanpagewhite
requested review from
alistairmc,
robpblake,
AdamJ,
staceymosier and
a user
|
I need to push up another commit with changes to the rhd.settings.php file to disable Drupal's CSS and JS preprocessing on local environments. I am testing that on my local environment now and will push up a commit in a moment. |
jordanpagewhite
changed the title
This disables Drupal's CSS and JS preprocessing and enables verbose logging on local environments.
|
retest this please |
7 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
There was some change made in this PR that breaks the Log in (Keycloak only) link in the top-right corner of of the top navbar. @jordanpagewhite to investigate. To clarify, the actual authentication process, etc. works, but the e2e tests cannot successfully get to sso.stage.redhat.com via that link. |
|
rebuild this please |
jordanpagewhite
removed request for
alistairmc,
robpblake,
AdamJ,
staceymosier and
a user
_docker/drupal/drupal-filesystem/web/themes/custom/rhdp2/rhd-frontend/package.json
Outdated
Show resolved
Hide resolved
|
I fixed the issue you pointed out (above) @staceymosier with the PFE dist filepaths. You should no longer see those console errors, and you should be able to see the src files in the Source tab of your Chrome inspector |
This adds CSS and JS sourcemaps to our rhdp2/rhd-frontend assets/build
process. This required removing some build logic that was moving dist
files around in Dockerfile.mp and dev/build-rhdp2-theme.sh, updating
paths across various FE build and config files and of course adding
to the existing node-sass command(s) in package.json to include the
building of sourcemaps.
JIRA Issue Link
Verification Process
You should see a directory structure like this in your Source tab: