Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update argocd-operator to fix sso test failure #529

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Jun 6, 2023

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:
1-050_validate_sso_config test is flaky due to a bug in argocd-operator which has been fixed with argoproj-labs/argocd-operator#922. This PR updates argocd-operator version to include that fix.

Which issue(s) this PR fixes:

Fixes GITOPS-2929

How to test changes / Special notes to the reviewer:
1-050_validate_sso_config test should pass consistently in openshift-ci

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbose78 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

Hi @svghadi. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@svghadi
Copy link
Member Author

svghadi commented Jun 6, 2023

/kind failing-test

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jun 6, 2023
@varshab1210
Copy link
Member

/ok-to-test

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Member Author

svghadi commented Jun 6, 2023

/retest

2 similar comments
@svghadi
Copy link
Member Author

svghadi commented Jun 6, 2023

/retest

@varshab1210
Copy link
Member

/retest

@varshab1210
Copy link
Member

Thanks @svghadi , looks good to me

@varshab1210
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2023

@svghadi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-kuttl-sequential 154893a link true /test v4.10-kuttl-sequential
ci/prow/v4.11-kuttl-sequential 154893a link true /test v4.11-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@varshab1210
Copy link
Member

/test v4.11-kuttl-sequential

@iam-veeramalla
Copy link
Collaborator

--- FAIL: kuttl/harness/1-042_validate_status_host (59.71s)

the above is a flaky test that is failing.

@iam-veeramalla iam-veeramalla merged commit f0932ae into redhat-developer:master Jun 12, 2023
@svghadi svghadi deleted the sso-e2e-fix branch June 12, 2023 08:27
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
chore: Update argocd-operator to fix sso test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a frequently failing test. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants