feat: Upgrade ArgoCD CRD to v1beta1 & add conversion webhook support #594
Conversation
|
CI jobs are failing with
Looks like it is due to operator-framework/operator-sdk#6323 |
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
/retest |
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
/lgtm |
|
/lgtm |
|
/test all |
|
/retest |
1 similar comment
|
/retest |
|
@svghadi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 9f7824a
into
redhat-developer:master
…edhat-developer#594) * Upgrade ArgoCD CRD to v1beta1 & add conversion webhook support Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix olm manifests generation Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix olm cert generation Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix rhsso test failure by updating test configs for new rhsso version Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * run code-gen make targets Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Abhishek Veeramalla <abhishek.veeramalla@gmail.com>
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR bring argoproj-labs/argocd-operator#964 into gitops-operator.
Changes:
How certs are handled for webhook?:
When operator is installed via OLM, the OLM takes care of cert generation and injection into operator manager pod.
For non-olm install, cert management is off-loaded to Openshift Service CA operator. The required annotations for this are already added in configs so no user action is required, however user needs to explicitly set env var
ENABLE_CONVERSION_WEBHOOKto"true"in operator manager deployment to enable the webhook.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
GITOPS-3040
How to test changes / Special notes to the reviewer:
Test instruction same as argoproj-labs/argocd-operator#964.
Automated test :
kubectl kuttl test ./test/openshift/e2e/parallel/ --config ./test/openshift/e2e/parallel/kuttl-test.yaml --test 1-103_argocd_alpha_to_beta_conversion