Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add script for installing nightly olm operator #604

Merged
merged 3 commits into from
Jan 22, 2024
Merged

feat: add script for installing nightly olm operator #604

merged 3 commits into from
Jan 22, 2024

Conversation

saumeya
Copy link
Member

@saumeya saumeya commented Sep 21, 2023 •
edited
Loading

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:

This PR includes the script needed to install the nightly operator bundle in a cluster. It takes the IIB id as a parameter and installs the operator using subscription (olm based).

To run the script , you have to export the IIB_ID

export IIB_ID=581525

There are 2 options -i and -m (for first install on the cluster or for migrating to nightly)

./olm-install-script -i
or
./olm-install-script -m

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Sep 21, 2023
@saumeya saumeya requested a review from anandf September 21, 2023 06:42
anandf
anandf reviewed Sep 21, 2023
View reviewed changes
hack/scripts/olm-nightly-install.sh Outdated
exit
fi

INDEX="brew.registry.redhat.io/rh-osbs/iib:$IIB_ID"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take in the registry/repository name as an environment variable with default values. brew.registry.redhat.io/rh-osbs - REGISTRY_NAME
iib - REPO_NAME

anandf
anandf reviewed Sep 21, 2023
View reviewed changes
hack/scripts/olm-nightly-install.sh Outdated
spec:
repositoryDigestMirrors:
- mirrors:
- registry.redhat.io/rh-sso-7/sso75-openshift-rhel8@sha256:d5829e880db4b82a50a4962d61ea148522a93644174931b256d7ad866eadcf40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be removed as it did not fix the issue of missing image in brew registry and we have moved to sso v7.6

anandf
anandf reviewed Sep 21, 2023
View reviewed changes
hack/scripts/olm-nightly-install.sh Outdated
EOF

# Wait for the operator to upgrade
NEW_BUILD="openshift-gitops-operator.v99.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better to have v99.9.0 as a variable and use that.

anandf
anandf requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes. Looks good otherwise.

anandf
anandf requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, otherwise looks good.

@saumeya saumeya requested a review from anandf September 26, 2023 15:25
@saumeya
Copy link
Member Author

saumeya commented Sep 27, 2023

/test v4.13-kuttl-parallel

anandf
anandf previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandf
Copy link
Member

anandf commented Sep 27, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Sep 27, 2023
@saumeya
Copy link
Member Author

saumeya commented Sep 28, 2023

/test v4.13-kuttl-parallel

@anandf
Copy link
Member

anandf commented Sep 28, 2023

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saumeya
Copy link
Member Author

saumeya commented Sep 29, 2023

/test v4.14-kuttl-parallel

1 similar comment
@saumeya
Copy link
Member Author

saumeya commented Sep 29, 2023

/test v4.14-kuttl-parallel

@saumeya @anandf
olm nightly install script
86a60b1 
fix

fix

fix

fix

fix

fix

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update ns

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add operator group

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

review changes

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add operator group

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

fixes

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@saumeya @anandf
fix
32ddf0f 
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@anandf
Copy link
Member

anandf commented Jan 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f0d8b69 into redhat-developer:master Jan 22, 2024
18 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
@saumeya @varshab1210
feat: add script for installing nightly olm operator (redhat-develope…
674183c 
…r#604)

* olm nightly install script

fix

fix

fix

fix

fix

fix

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update ns

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add operator group

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

review changes

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

add operator group

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

fixes

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* fix

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

---------

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Co-authored-by: Varsha B <vab@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandf anandf anandf left review comments

@reginapizza reginapizza Awaiting requested review from reginapizza

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@anandf anandf

Labels
approved kind/enhancement New feature or request lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saumeya @anandf @varshab1210