Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 1-090_validate_permissions test #694

Merged

Conversation

varshab1210
Copy link
Member

What type of PR is this?

kind failing-test

What does this PR do / why we need it:

Disable 1-090_validate_permissions test to unblock CI checks

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Varsha B <vab@redhat.com>
@varshab1210 varshab1210 changed the title disable 1-090_validate_permissions Disable 1-090_validate_permissions test May 2, 2024
Copy link

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from varshab1210. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshab1210
Copy link
Member Author

/test v4.13-e2e

@jgwest
Copy link
Collaborator

jgwest commented May 3, 2024

/test all

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

5 similar comments
@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest
Copy link
Collaborator

jgwest commented May 8, 2024

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 8, 2024
@jgwest jgwest merged commit f9ab21e into redhat-developer:master May 8, 2024
17 of 18 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Signed-off-by: Varsha B <vab@redhat.com>
Co-authored-by: Jonathan West <jgwest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants