Support for Evaluation of CompletionStage and Uni Objects

[angelozerr]

Support for Evaluation of CompletionStage and Uni Objects

Fixes #826

[angelozerr]

Here the file that I have used for test:

{@java.util.concurrent.CompletableFuture<java.util.List<String>> items}

{#for item in items}
	{item.blank}
{/for}

and here a demo:

[angelozerr]

I notice that there are some trouble when the expected items is not an iterable like:

{@String items}

{#for item in items}
	{item.blank}
{/for}

We have a popup error when we try to hover name property, teh inlay hint shows String after item although it should not show the type. I need to investigate the problem.

But I think the problem is the same in master.

[fbricon]

WRAPPER_TYPES

[angelozerr]

fixed

[datho7561]

These are the types that do the wrapping, so they should be called WRAPPER_TYPES. The wrapped type is the type parameter eg. in Uni<List<String>>, uni is wrapping List<String>, List<String> is wrapped by Uni, Uni is a wrapper type, List<String> is a wrapped type.

[angelozerr]

We have a popup error when we try to hover name property, teh inlay hint shows String after item although it should not show the type. I need to investigate the problem.

It should be fixed.

[angelozerr]

Ok the PR can be reviewed now. I have wrotten a lot of tests, so I'm more confident to integrate it in the release.

@fbricon @datho7561 @JessicaJHee please play with my PR to check I have not broken something.

[datho7561]

Doesn't seem to be working for me:

[datho7561]

Actually, the completion is working, the code lens for the {#if is working, but the validation is not working. Another case where it's broken:

[angelozerr]

@datho7561 is the sample #832 (comment) is working for you?

[angelozerr]

Could you share your sample please.

[datho7561]

CompletionStagePOJO.java

package org.acme;

import java.util.Arrays;
import java.util.List;
import java.util.concurrent.CompletableFuture;

import io.smallrye.mutiny.Uni;

public class CompletionStagePOJO {
    public Uni<List<String>> getMyStrings() {
        return Uni.createFrom().item(Arrays.asList("my string", "my other string"));
    }

    public CompletableFuture<List<String>> getOtherStrings() {
        return CompletableFuture.completedFuture(Arrays.asList("my string", "my other string"));
    }
}

completion-stage-template.html

{@org.acme.CompletionStagePOJO obj}

{#for stringElt in obj.myStrings}
    {stringElt.codePointAt(0)}
{/for}

{obj.myStrings.add("sandwich")}

[angelozerr]

Doesn't seem to be working for me:

It should working now, I didn't the cover of Java Type returned by a method. Thanks for haved testing this usecase.

[datho7561]

The code is working well, I haven't run into any bugs. I added a few comments, but feel free to merge once you've addressed them.

[datho7561]

These are the types that do the wrapping, so they should be called WRAPPER_TYPES. The wrapped type is the type parameter eg. in Uni<List<String>>, uni is wrapping List<String>, List<String> is wrapped by Uni, Uni is a wrapper type, List<String> is a wrapped type.