Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move utilities out of extension.ts #2824

Merged
merged 6 commits into from
Dec 5, 2022
Merged

refactor: move utilities out of extension.ts #2824

merged 6 commits into from
Dec 5, 2022

Conversation

Eskibear
Copy link
Contributor

@Eskibear Eskibear commented Dec 2, 2022

benefits:

  • avoid circular dependencies related to extension.ts
  • shrink size of extension.ts for better readability

@Eskibear
extract OutputInfoCollector from extension.ts
0935f1e 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
extract ClientErrorHandler from extension.ts
42040b5 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
move hasBuildToolConflicts to utils.ts
dc0ee18 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
move getJavaConfig to utils.ts
c96da25 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
move constant cleanWorkspaceFileName into settings.ts
7bc2ab4 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
move applyWorkspaceEdit to standardLanguageClient.ts
d70d1eb 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
testforstephen
testforstephen approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testforstephen testforstephen merged commit 17bfd19 into redhat-developer:master Dec 5, 2022
@Eskibear Eskibear deleted the refactor-extension-ts branch December 5, 2022 07:06
@rgrunber rgrunber added this to the Early January 2023 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
Mid January 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eskibear @testforstephen @rgrunber