Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding 'restricted' to SecurityContextConfig when creating a Catalog #1175

Merged
merged 1 commit into from
Jun 10, 2024
Merged

adding 'restricted' to SecurityContextConfig when creating a Catalog #1175

merged 1 commit into from
Jun 10, 2024

Conversation

acornett21
Copy link
Contributor

  • Fixes: Update CatalogSource Logic to Support OCP 4.16 PodSecurity  #1169
  • Updating CatalogSource creation to include SecurityContextCOnfig type of restricted.
  • Applying this globally with no conditional logic since this is works as expected for the versions of OCP that are currently supported (4.12-4.15), and solves the problem on 4.16.

@openshift-ci openshift-ci bot requested a review from tonytcampbell June 6, 2024 21:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@acornett21
adding 'restricted' to SecurityContextConfig when creating a CatalogS…
6c01c3a 
…ource

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21 acornett21 changed the title adding 'restricted' to SecurityContectConfig when creating a Catalog adding 'restricted' to SecurityContextConfig when creating a Catalog Jun 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 84.79% (+0.008%) from 84.782%
when pulling 6c01c3a on acornett21:catalogsource
into 3bdeab0 on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Jun 6, 2024

from change #1175:

@acornett21
Copy link
Contributor Author

/test 4.12-e2e

bcrochet
bcrochet approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
komish
komish approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit c1c7a70 into redhat-openshift-ecosystem:main Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@bcrochet bcrochet bcrochet approved these changes

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CatalogSource Logic to Support OCP 4.16 PodSecurity
5 participants
@acornett21 @coveralls @dcibot @bcrochet @komish