(#2138081) More chase_symlinks*() shenanigans
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when /proc is not mounted" This reverts commit 47c0c51. Related: #2138081
(cherry picked from commit 03c16b9) Related: #2138081
…bother with /proc/ Replaces: #25581 (cherry picked from commit 2075b6d) Related: #2138081
…proc/ (cherry picked from commit 0f958c8) Related: #2138081
It's a bashism, but we use other bash features anyway, and it's cleaner and much less verbose. (cherry picked from commit 1f9caf2) Related: #2138081
systemd-rhel-bot
changed the title
chase_symlinks*() shenaniganschase_symlinks*() shenanigans
|
@jamacku we need to wait with this one until systemd/systemd#25661 is sorted out. On top of that we will need to change rpm macros and add |
systemd-rhel-bot
changed the title
chase_symlinks*() shenaniganschase_symlinks*() shenanigans
jamacku
changed the title
chase_symlinks*() shenaniganschase_symlinks*() shenanigans
Trying to disable a unit with no install info is mostly useless, so adding a warning like we do for enable (with the new dbus method 'DisableUnitFilesWithFlagsAndInstallInfo()'). Note that it would still find and remove symlinks to the unit in /etc, regardless of whether it has install info or not, just like before. And if there are actually files to remove, we suppress the warning. Fixes #17689 (cherry picked from commit bf1bea4) Related: #2141979
In cases like packaging scripts, it might be desired to use enable/disable on units without install info. So, adding an option '--no-warn' to suppress the warning. (cherry picked from commit 108d35a) Related: #2141979
Suppress the "empty [Install] section" warning (see #25437). (cherry picked from commit 0acb145) Related: #2141979
(cherry picked from commit 93b0ec8) Related: #2141979
msekletar
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
@mrc0mmand thanks for following up on this, much appreciated!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts & backports the new set of patches for the recent
chase_symlinks*()without/proc/issue.For RHEL we either want to backport systemd/systemd#25661 as well once it's merged, or drop the warning completely/lower it to debug, hence opening this as a draft for now.
/cc @msekletar