Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2052106) Net naming scheme for RHEL-9.0 #68

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

jacekmigacz
Copy link
Member

No description provided.

@msekletar
Copy link
Member

@jacekmigacz thank you preparing the PR! However, I am now looking at the associated BZ and to be quite honest I don't see a good reason do deviate from upstream naming scheme. I will request more information from the reporter.

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-ci Formerly needs-ci label Feb 4, 2022
@jamacku jamacku mentioned this pull request Feb 8, 2022
10 tasks
@msekletar msekletar changed the title (#2005367) Net naming scheme for RHEL-9.0 (#2052106) Net naming scheme for RHEL-9.0 Feb 8, 2022
@msekletar
Copy link
Member

I was about to LGTM on this one, but I've noticed that in the original BZ reported said it is not worth to deviate from the upstream naming scheme, so I've closed that bug.

@jacekmigacz I've created new bug requesting the addition of rhel-9.0 naming scheme (w/o changes that were originally requested) and I've also updated description of this PR. Please update Resolves: in your commit message and update this PR. Thanks!

@systemd-rhel-bot systemd-rhel-bot added the tracker/unapproved Formerly needs-acks label Feb 8, 2022
RHEL-only

Resolves: #2052106
@systemd-rhel-bot systemd-rhel-bot added pr/needs-ci Formerly needs-ci and removed pr/needs-ci Formerly needs-ci labels Feb 8, 2022
@jacekmigacz
Copy link
Member Author

@msekletar thanks for creating bz for me I forgot to do it. Force-pushed with new bz# in Resolves:.

@jamacku jamacku added this to the RHEL-9.0 milestone Feb 9, 2022
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Feb 15, 2022
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Feb 22, 2022
@systemd-rhel-bot systemd-rhel-bot merged commit 464a8fc into redhat-plumbers:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants