V2 #125
Merged
V2 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial file structure Update paths to files in setup.py Update documentation for run function Fix return code of pytest if not tests are found
Add CA base interface ca.py Add implementation of the LocalCA class Add unit tests Add unit tests Update documentation Update metadata about package Add fixture for backping sssd ca db Update setup.py to include package data Update for review Update docs
Add unit tests for IPA server CA Disable auxiliary logs from not important loggers Update docs and logs Add test for force option Move IPAServerCA to CA.py Add assertion for making requests to IPA server via ClientMeta Update linter Fix renaming of the cert output Add unit test for IPA server CA Remove redundant test Update for review Remove hardcoded admin password Add propagation of default env values to pytest env
Move functions to static methods
Method prepare creates and modifies sssd.conf file during setup. Method set can be used during testing phase (different runtime) to introduce test-specific modification to sssd.conf file by using default backup file as input and applying changes on top of it. However, method prepare did not update default backup file after user-spefific matchrules were added leading to loss of these changes in case sssd.conf file was futrher modified by tests.
IPAServerCA was trying to obtain config-client-for-smart-card-auth.sh from IPA server. Now it will check for it's existance before trying to obtain it. Moving imports of paramiko, invoke and fabric to a method obtaining script from IPA. Having them as lazy imports will prevent failures on imports in case this branch of code is not executed.
This module implements GUI class, which can be imported into tests and used as context manager. This class enables interaction with GUI of the system under test. Most importantly, the GUI class is responsible for taking screenshots and controlling the input devices like mouse and keybord. The class implements a high level API with functions like click_on, which takes the screenshot, finds a string in it and clicks on corresponding coordinate on the screen.
The module provides context managed function assert_log. It can assert, that a new log has been written in time between entering and exiting the context manager.
GeorgePantelakis
approved these changes
Nov 9, 2023
|
uf, unfortunately, from this PR it is not clear what was actually changed... so I can't provide a more specific review of this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.