Change the PUT and POST method in the tutorials #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convention of the POST method in HTTP should be for creating a new resource. And PUT method for updating specific resource
👷 Deploy request for redis-stack-docs pending review.Visit the deploys page to approve it
|
|
Pull-request on the 'starter code' to update the Swagger UI spec: redis-developer/express-redis-om-workshop#2 (comment) |
leibale
approved these changes
Dec 1, 2022
guyroyse
reviewed
Dec 1, 2022
| @@ -342,7 +342,7 @@ Now that we can read and write, let's implement the *REST* of the HTTP verbs. RE | |||
| Let's add the code to update a person using a POST route: | |||
There was a problem hiding this comment.
Need to update the prose to match the code.
| @@ -283,7 +283,7 @@ Now we can add our routes to create, read, update, and delete persons. Head back | |||
| We'll create a person first as you need to have persons in Redis before you can do any of the reading, writing, or removing of them. Add the PUT route below. This route will call `.createAndSave()` to create a `Person` from the request body and immediately save it to the Redis: | |||
There was a problem hiding this comment.
Need to update the prose to match the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention of the POST method in HTTP should be for creating a new resource. And PUT method for updating specific resource