Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pipeline & Transaction + Examples #68

Merged
merged 10 commits into from
Feb 7, 2023
Merged

Support Pipeline & Transaction + Examples #68

merged 10 commits into from
Feb 7, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jan 22, 2023

Closes #60
Closes #61
Closes #62
Closes #63
Closes #64
Closes #65
Closes #66
Closes #78

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 93.32% // Head: 93.36% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (0d3094c) compared to base (1c26a8c).
Patch coverage: 88.88% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   93.32%   93.36%   +0.03%     
==========================================
  Files          76       77       +1     
  Lines        4555     4566      +11     
  Branches      422      422              
==========================================
+ Hits         4251     4263      +12     
  Misses        181      181              
+ Partials      123      122       -1     
Impacted Files Coverage Δ
src/NRedisStack/Transactions.cs 88.23% <88.23%> (ø)
src/NRedisStack/Pipeline.cs 100.00% <100.00%> (ø)
src/NRedisStack/Search/Document.cs 86.00% <0.00%> (+6.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash changed the title Add HSET & SEARCH Example Add Examples Jan 22, 2023
@chayim
Copy link
Contributor

chayim commented Jan 24, 2023

CC @uglide

shacharPash and others added 5 commits January 29, 2023 16:38
* added pipelineexamples and docs

* adding pipelinewithAsync example

* Adding a README to the nuget package (#76)

* Adding a README to the nuget package

* readme path

* fixing readme path

* adding pipelinewithasync doc feedback changes

* feedback changes

* fix examples

* fix JsonWithSearchPipeline test

* Add delay before search

* Change to one consractor for Pipeline that get IDatabase

---------

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: shacharPash <shachar.pashchur@redis.com>
* added pipelineexamples and docs

* adding pipelinewithAsync example

* adding pipelinewithasync doc feedback changes

* added transaction support

* fixing docs and transactions methods

* adding transaction test01

* adding transactions tests

* fix test

* fixes

* add TestModulsTransaction

---------

Co-authored-by: shacharPash <shachar.pashchur@redis.com>
@shacharPash shacharPash marked this pull request as ready for review February 6, 2023 08:24
@shacharPash shacharPash requested review from chayim and a team and removed request for a team and chayim February 6, 2023 08:24
@shacharPash
Copy link
Contributor Author

This PR contains 3 main things:

  1. Pipeline support.
  2. Transaction support.
  3. Examples of the two sections above, and more examples of using NRedisStack.

@shacharPash shacharPash requested review from chayim and a team February 6, 2023 09:39
@shacharPash shacharPash changed the title Add Examples Support Pipeline & Transaction + Examples Feb 6, 2023
Copy link
Contributor Author

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chayim chayim merged commit 5ccb704 into master Feb 7, 2023
@chayim chayim deleted the examples branch February 7, 2023 12:08
@shacharPash shacharPash added documentation Improvements or additions to documentation feature labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment