Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not enough arguments in call to client.cmdable.Ping #1333

Closed
arslantopcu1 opened this issue May 21, 2020 · 10 comments
Closed

not enough arguments in call to client.cmdable.Ping #1333

arslantopcu1 opened this issue May 21, 2020 · 10 comments
Labels
Stale

Comments

@arslantopcu1
Copy link

No description provided.

@Alkass
Copy link

Alkass commented May 22, 2020

I started seeing the same error after a recent update. The snippets in Readme.md haven't been updated

@00LT00
Copy link

00LT00 commented May 23, 2020

How can I change my code now....

@allthingsclowd
Copy link

I came across this issue with my development pipeline this week.

Warning: I'm not a developer!

I fixed this by configuring Go Modules in my repo so that I could lock the specific release of the go-redis package.

As soon as I enabled go modules and ran a dummy test cycle to populate the newly created go.mod file everything kicked into life!

I thought that I would have had to set the version of the redis build manually in the go.mod file but there appears to be native intelligence built into this dependency flow that manages this - at least it did for me.

Steps that I followed:

In the root of my repo where my sample main.go lives at did the following:

  1. Initialise the golang repo to utilise the go modules dependency system
    go mod init

  2. Run a dummy test [dummy as I have not written ANY tests - someday....]
    go test

As soon as I committed the changes to github everything kicked back into life in Travis-CI....well from the Redis point of view...my scripts are another issue altogether :)

Hopefully this may help someone.

$ go mod init
go: creating new go.mod: module github.com/allthingsclowd/web_page_counter
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ cat go.mod
module github.com/allthingsclowd/web_page_counter

go 1.12
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ go test
go: finding github.com/DataDog/datadog-go/statsd latest
go: finding github.com/gorilla/mux v1.7.4
go: finding github.com/hashicorp/consul/api v1.4.0
go: finding github.com/hashicorp/vault/api v1.0.4
go: downloading github.com/gorilla/mux v1.7.4
go: extracting github.com/gorilla/mux v1.7.4
go: finding github.com/go-redis/redis v6.15.8+incompatible
go: downloading github.com/go-redis/redis v6.15.8+incompatible
go: extracting github.com/go-redis/redis v6.15.8+incompatible
go: finding github.com/DataDog/datadog-go v3.7.1+incompatible
go: downloading github.com/DataDog/datadog-go v3.7.1+incompatible
go: extracting github.com/DataDog/datadog-go v3.7.1+incompatible
go: downloading github.com/hashicorp/consul/api v1.4.0
go: extracting github.com/hashicorp/consul/api v1.4.0
go: downloading github.com/hashicorp/vault/api v1.0.4
go: extracting github.com/hashicorp/vault/api v1.0.4
go: finding github.com/hashicorp/vault/sdk v0.1.13
go: finding github.com/hashicorp/consul/sdk v0.4.0
go: finding github.com/hashicorp/hcl v1.0.0
go: finding github.com/hashicorp/go-cleanhttp v0.5.1
go: finding github.com/hashicorp/go-rootcerts v1.0.1
go: finding github.com/hashicorp/go-retryablehttp v0.5.4
go: finding github.com/hashicorp/errwrap v1.0.0
go: finding github.com/stretchr/testify v1.4.0
go: finding golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: finding gopkg.in/square/go-jose.v2 v2.3.1
go: finding github.com/hashicorp/serf v0.8.2
go: finding github.com/pkg/errors v0.8.1
go: finding github.com/fatih/color v1.9.0
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3
go: finding github.com/go-ldap/ldap v3.0.2+incompatible
go: finding github.com/hashicorp/go-multierror v1.0.0
go: finding github.com/hashicorp/go-hclog v0.8.0
go: finding gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d
go: finding github.com/mitchellh/mapstructure v1.1.2
go: finding github.com/mitchellh/copystructure v1.0.0
go: finding github.com/ryanuber/go-glob v1.0.0
go: finding gopkg.in/yaml.v2 v2.2.2
go: finding google.golang.org/grpc v1.22.0
go: finding golang.org/x/net v0.0.0-20181201002055-351d144fa1fc
go: finding github.com/hashicorp/go-sockaddr v1.0.2
go: finding github.com/mattn/go-colorable v0.1.4
go: finding github.com/mitchellh/go-testing-interface v1.0.0
go: finding github.com/pascaldekloe/goe v0.1.0
go: finding github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f
go: finding gopkg.in/yaml.v2 v2.2.8
go: finding golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: finding github.com/golang/protobuf v1.3.1
go: finding github.com/hashicorp/go-rootcerts v1.0.2
go: finding github.com/hashicorp/go-immutable-radix v1.0.0
go: finding github.com/mitchellh/reflectwalk v1.0.0
go: finding github.com/hashicorp/golang-lru v0.5.1
go: finding golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: finding github.com/mattn/go-isatty v0.0.8
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/fatih/structs v1.1.0
go: finding google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
go: finding github.com/hashicorp/go-msgpack v0.5.3
go: finding github.com/davecgh/go-spew v1.1.0
go: finding github.com/hashicorp/go-cleanhttp v0.5.0
go: finding github.com/hashicorp/go-uuid v1.0.0
go: finding github.com/hashicorp/yamux v0.0.0-20181012175058-2f1d1f20f75d
go: finding github.com/mattn/go-isatty v0.0.12
go: finding github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e
go: finding golang.org/x/text v0.3.0
go: finding github.com/mitchellh/mapstructure v0.0.0-20160808181253-ca63d7c062ee
go: finding github.com/golang/protobuf v1.2.0
go: finding github.com/stretchr/objx v0.1.0
go: finding golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223
go: finding golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: finding github.com/hashicorp/memberlist v0.1.3
go: finding github.com/hashicorp/go-plugin v1.0.1
go: finding github.com/mitchellh/go-wordwrap v1.0.0
go: finding github.com/hashicorp/go-uuid v1.0.1
go: finding github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da
go: finding github.com/davecgh/go-spew v1.1.1
go: finding github.com/mitchellh/iochan v1.0.0
go: finding github.com/hashicorp/golang-lru v0.5.0
go: finding github.com/golang/mock v1.1.1
go: finding github.com/hashicorp/logutils v1.0.0
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/client9/misspell v0.3.4
go: finding golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be
go: finding github.com/oklog/run v1.0.0
go: finding golang.org/x/text v0.3.1-0.20181227161524-e6919f6577db
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15
go: finding github.com/BurntSushi/toml v0.3.1
go: finding github.com/golang/snappy v0.0.1
go: finding google.golang.org/grpc v1.14.0
go: finding golang.org/x/net v0.0.0-20180826012351-8a410e7b638d
go: finding golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3
go: finding github.com/miekg/dns v1.0.14
go: finding golang.org/x/net v0.0.0-20181023162649-9b4f9f5ad519
go: finding github.com/hashicorp/go-syslog v1.0.0
go: finding cloud.google.com/go v0.26.0
go: finding honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc
go: finding github.com/kr/pretty v0.2.0
go: finding github.com/hashicorp/go-hclog v0.12.0
go: finding google.golang.org/genproto v0.0.0-20190404172233-64821d5d2107
go: finding github.com/google/go-cmp v0.2.0
go: finding github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529
go: finding golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: finding google.golang.org/appengine v1.4.0
go: finding github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310
go: finding github.com/hashicorp/go-hclog v0.0.0-20180709165350-ff2cf002a8dd
go: finding gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405
go: finding github.com/mitchellh/cli v1.0.0
go: finding golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e
go: finding golang.org/x/sys v0.0.0-20200116001909-b77594299b42
go: finding golang.org/x/sys v0.0.0-20190403152447-81d4e9dc473e
go: finding github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c
go: finding github.com/ryanuber/columnize v2.1.0+incompatible
go: finding github.com/mitchellh/go-testing-interface v0.0.0-20171004221916-a61a99592b77
go: finding github.com/mattn/go-isatty v0.0.11
go: finding google.golang.org/grpc v1.19.0
go: finding golang.org/x/lint v0.0.0-20190227174305-5b3e6a55c961
go: finding golang.org/x/sys v0.0.0-20190129075346-302c3dd5f1cc
go: finding github.com/hashicorp/yamux v0.0.0-20180604194846-3520598351bb
go: finding github.com/hashicorp/go-version v1.1.0
go: finding github.com/mitchellh/gox v0.4.0
go: finding golang.org/x/exp v0.0.0-20190121172915-509febef88a4
go: finding github.com/stretchr/testify v1.3.0
go: finding golang.org/x/tools v0.0.0-20190226205152-f727befe758c
go: finding golang.org/x/tools v0.0.0-20190524140312-2c0ae7006135
go: finding google.golang.org/appengine v1.1.0
go: finding github.com/pierrec/lz4 v2.0.5+incompatible
go: finding golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc
go: finding golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3
go: finding github.com/posener/complete v1.1.1
go: finding github.com/fatih/color v1.7.0
go: finding golang.org/x/net v0.0.0-20190213061140-3a22650c66bd
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go: finding github.com/mattn/go-colorable v0.0.9
go: finding github.com/mattn/go-isatty v0.0.3
go: finding golang.org/x/sys v0.0.0-20191026070338-33540a1f6037
go: finding github.com/hashicorp/go-sockaddr v1.0.0
go: finding github.com/go-test/deep v1.0.2-0.20181118220953-042da051cf31
go: finding golang.org/x/sys v0.0.0-20181026203630-95b1ffbd15a5
go: finding github.com/kr/text v0.1.0
go: finding golang.org/x/tools v0.0.0-20190114222345-bf090417da8b
go: finding github.com/bgentry/speakeasy v0.1.0
go: finding github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c
go: finding golang.org/x/tools v0.0.0-20190311212946-11955173bddd
go: finding golang.org/x/sys v0.0.0-20180830151530-49385e6e1522
go: finding github.com/hashicorp/mdns v1.0.0
go: finding github.com/mattn/go-isatty v0.0.10
go: finding honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099
go: finding golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f
go: finding golang.org/x/sync v0.0.0-20190227155943-e225da77a7e6
go: finding golang.org/x/crypto v0.0.0-20181029021203-45a5f77698d3
go: finding golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4
go: finding github.com/stretchr/testify v1.2.2
go: finding github.com/kr/pty v1.1.1
go: finding golang.org/x/sys v0.0.0-20191008105621-543471e840be
go: finding golang.org/x/sync v0.0.0-20181108010431-42b317875d0f
go: finding github.com/hashicorp/go.net v0.0.1
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: downloading github.com/hashicorp/vault/sdk v0.1.13
go: downloading gopkg.in/square/go-jose.v2 v2.3.1
go: downloading github.com/mitchellh/mapstructure v1.1.2
go: downloading github.com/hashicorp/go-retryablehttp v0.5.4
go: extracting golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
go: downloading github.com/hashicorp/go-multierror v1.0.0
go: extracting github.com/mitchellh/mapstructure v1.1.2
go: extracting github.com/hashicorp/go-retryablehttp v0.5.4
go: downloading github.com/hashicorp/errwrap v1.0.0
go: downloading github.com/hashicorp/go-rootcerts v1.0.2
go: downloading github.com/hashicorp/serf v0.8.2
go: downloading github.com/hashicorp/hcl v1.0.0
go: extracting github.com/hashicorp/go-multierror v1.0.0
go: extracting github.com/hashicorp/errwrap v1.0.0
go: extracting github.com/hashicorp/go-rootcerts v1.0.2
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading github.com/hashicorp/go-hclog v0.12.0
go: extracting gopkg.in/square/go-jose.v2 v2.3.1
go: extracting github.com/hashicorp/hcl v1.0.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: extracting github.com/hashicorp/go-hclog v0.12.0
go: extracting github.com/hashicorp/vault/sdk v0.1.13
go: downloading github.com/fatih/color v1.9.0
go: extracting github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: extracting github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/hashicorp/go-sockaddr v1.0.2
go: downloading github.com/pierrec/lz4 v2.0.5+incompatible
go: downloading github.com/golang/snappy v0.0.1
go: downloading github.com/ryanuber/go-glob v1.0.0
go: extracting github.com/mattn/go-isatty v0.0.12
go: downloading golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: extracting github.com/ryanuber/go-glob v1.0.0
go: extracting github.com/golang/snappy v0.0.1
go: extracting github.com/hashicorp/go-sockaddr v1.0.2
go: extracting github.com/fatih/color v1.9.0
go: downloading github.com/mattn/go-colorable v0.1.4
go: extracting github.com/mattn/go-colorable v0.1.4
go: extracting github.com/hashicorp/serf v0.8.2
go: extracting golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da
go: extracting github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da
go: downloading github.com/hashicorp/go-immutable-radix v1.0.0
go: extracting github.com/hashicorp/go-immutable-radix v1.0.0
go: downloading github.com/hashicorp/golang-lru v0.5.1
go: extracting github.com/hashicorp/golang-lru v0.5.1
go: downloading golang.org/x/text v0.3.1-0.20181227161524-e6919f6577db
go: extracting github.com/pierrec/lz4 v2.0.5+incompatible
go: extracting golang.org/x/sys v0.0.0-20200124204421-9fbb57f87de9
go: extracting golang.org/x/text v0.3.1-0.20181227161524-e6919f6577db
?       github.com/allthingsclowd/web_page_counter      [no test files]
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ cat go.mod
module github.com/allthingsclowd/web_page_counter

go 1.12

require (
        github.com/DataDog/datadog-go v3.7.1+incompatible
        github.com/go-redis/redis v6.15.8+incompatible
        github.com/gorilla/mux v1.7.4
        github.com/hashicorp/consul/api v1.4.0
        github.com/hashicorp/vault/api v1.0.4
)
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ git add -A
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ git commit -m "Added go.mod file to help with new go redis module version issues"
[new_cert_bootstrapping 82f4594] Added go.mod file to help with new go redis module version issues
 2 files changed, 191 insertions(+)
 create mode 100644 go.mod
 create mode 100644 go.sum
~/vagrant_workspace/pipeline (new_cert_bootstrapping)
$ git push

@allthingsclowd
Copy link

No description provided.

#1333 (comment) may help?

@kzkzzzz
Copy link

kzkzzzz commented May 24, 2020 •
edited
Loading

I try to use like this

client := redis.NewClient(&redis.Options{
	Addr: "127.0.0.1:6379",
	Password: "",
	DB: 0,
})
pong,err := client.Ping(client.Context()).Result()

@mshirley
Copy link

the recent v8 merge into master broke all existing code. adding client.Context() to the call arguments fixed the issue.

@eroncastro
Copy link

IMHO, it is really odd having to pass client.Context() whenever you issue a redis command.

This was referenced May 26, 2020
Merged
Closed
@ps-jessejjohnson
Copy link

You may also use context.TODO() as the Context package documentation suggests:

Code should use context.TODO when it's unclear which Context to use or it is not yet available (because the surrounding function has not yet been extended to accept a Context parameter).

@rektbuildr rektbuildr mentioned this issue Jun 4, 2020
Closed
@wolfy1339 wolfy1339 mentioned this issue Jun 25, 2020
Open
@dhrubodeepbasumatary
Copy link

I try to use like this

client := redis.NewClient(&redis.Options{
	Addr: "127.0.0.1:6379",
	Password: "",
	DB: 0,
})
pong,err := client.Ping(client.Context()).Result()

This worked fine for me!!

@github-actions
Copy link

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Sep 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mshirley @Alkass @eroncastro @allthingsclowd @dhrubodeepbasumatary @kzkzzzz @00LT00 @ps-jessejjohnson @arslantopcu1