Add BitMapCmdable to Cmdable. #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofekshenawa, I saw you reviewed #2725. This is a similar PR to fix a similar issue. Could you take look? |
|
That's Cool |
Goldziher
approved these changes
Oct 1, 2023
rentziass
approved these changes
Oct 3, 2023
|
@ofekshenawa, thanks for the ✅! Is there ETA on when this will be released? This PR will resolve an open issue with redismock used with go-redis 9.2 |
|
ping |
|
ping2 |
|
ping |
|
I apologize for the delayed response. |
|
ping |
ofekshenawa
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #2736 and go-redis/redismock#83
I copied the approach in #2725, and reviewed the changes in #2716 for other interfaces we might need to add (didn't find any others).
I added
BitMapCmdableand sorted the list for readability.