Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support write the types of pointer of simple data types (#2745) #2753

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

tzq0301
Copy link
Contributor

@tzq0301 tzq0301 commented Oct 11, 2023

No description provided.

@ofekshenawa
Copy link
Collaborator

Hey,
Do you think you might be able to write a unit test that validates this? WDYT?

@tzq0301
Copy link
Contributor Author

tzq0301 commented Oct 29, 2023

Hey, Do you think you might be able to write a unit test that validates this? WDYT?

Hello. I have added a unit test for WriteArg to test the behaviour of the simple data types and the pointer type of them.

The result of the unit test shows that WriteArg the value of the pointer of the simple data types have the same behaviour as the non-pointer types after the modification of internal/proto/writer.go in this PR.

@ofekshenawa ofekshenawa merged commit 15682e3 into redis:master Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] HSet struct with pointer
2 participants