Change Z member type to string #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvora-h
approved these changes
Dec 3, 2023
|
You don't do semantic versioning in go-redis? This is a breaking change. |
|
This change breaks our code zalando/skipper#2806 as we used int64 |
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Jan 2, 2024
There was a breaking change to go-redis library redis/go-redis#2818 I've checked how it handles interface{} command arguments and it converts int64 to string so this change should fix the problem. Closes #2806 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
This change seems to be a mistake. Going by the spec, all values in Redis are "strings", including Also, this is a semver breaking change pushed in a minor version that just broke our codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2817