feat: support round robin replica selection #2946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukriish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our production clusters, where we use
SlaveForKeyfunction to selectively runEVALSHA, we noticed that the replica selection strategy was random and resulted in an uneven traffic pattern. During high throughput this started showing up with noticeable resource utilisation on some of the nodes compared to other. Ideally this wouldn't have made too big an issue but since we are running lua scripts andevalsha, it was noticeable.I checked to see if there was a way for clients to inject a routing strategy via ClusterOptions but it isn't supported. Ideally, I think that might make more sense, especially since the client already supports
SlaveForKey,MasterForKey,ForEachMasterandForEachSlavemethods. Immediately for our use case I decide to just add a new route strategy but it might make sense to support custom route functions.Please let me know if this makes sense to be merged back here.