Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to Close Sentinel when the NewFailoverClusterClient is Closed. #2968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Attempt to Close Sentinel when the NewFailoverClusterClient is Closed. #2968

wants to merge 1 commit into from

Conversation

DevineLiu
Copy link

We should have a means to reclaim the sentinels' connection resources established by NewFailoverClusterClient.

@monkey92t
Copy link
Collaborator

I didn't understand this PR. What does it mean?

@DevineLiu
Copy link
Author

When using NewFailoverClusterClient for initialization, at line 788, the code initializes connections to the Sentinels, and at line 792, the client subscribes to the Sentinel. However, the long-lived connection between the client and the Sentinel doesn't get closed when Close is called on the ClusterClient returned by NewFailoverClient.

This issue occurs when the Close method is called on ClusterClient, and the long-lived connection to the Sentinel is not closed along with it.

@DevineLiu DevineLiu changed the title Attempt to Close Sentinel when the cluster is Closed. Attempt to Close Sentinel when the NewFailoverClusterClient is Closed. Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevineLiu @monkey92t