Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol error #1106

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Fix protocol error #1106

merged 3 commits into from
Sep 5, 2022

Commits on Sep 4, 2022

  1. Fix ProtocolError

    mtuleika-appcast authored and michael-grunder committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    5c59b60 View commit details
    Browse the repository at this point in the history
  2. Attempt to fix protocol error in a generic way

    This commit attempts to fix hiredis such that a recoverable write error
    will be retried rather than throwing a hard error.
    
    Since our read/write functions are now behind function pointers, we
    specify semantically that a return value of < 0 is a hard error, 0 a
    recoverable error, and > 0 a success.
    
    Our default `redisNetRead` function was already doing something similar
    so this also improves code consistency.
    
    See #961
    michael-grunder committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    3ab3e87 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Configuration menu
    Copy the full SHA
    7e8df51 View commit details
    Browse the repository at this point in the history