-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support pull request #52
Conversation
…eanup and additional fixes.
…eanup and additional fixes.
Conflicts: hiredis.c net.c Resolved
…fault to make PING/PONG and connect work.
…s, e.g. 5, to (size_t) to be portable to win64. Otherwise it will be considered an int, which causes problems only on the 4th argument (!) due to x64 ABI. See http://stackoverflow.com/questions/727663/why-does-this-variadic-function-fail-on-4th-parameter-on-windows-x64
Upgrade from 0.10.1 (February 2012) to the latest 0.11 from official hiredis repository.
I have updated my Windows 'fixes' and cleanups to fix another bug, and have merged in the latest v0.11. |
_WIN32 is automatically defined on Windows 32-bit and 64-bit by both MSVC++ and MinGW.
@moreaki , I replaced the custom define |
My comment on the issue with Windows support is the same as in #139.
@koenvandesande If you maintain this Windows fork, I'd be more than happy to link to it from the README. |
The main official C client should support win32. Possibility of having broken build is better that not having any build at all. This is a very usefull feature and if it is broken a lot of developers will be glad to fix it. |
I agree about the need for Windows support. For CI, there is Visual Studio Online. Is there any possibility to get this pull merged? |
Any news? Because now when I try to install Rails 5 Beta1 hiredis gem version 0.5.2 is required and I can't do that because it's not compatible with windows so what can I do? Thanks |
Wait for the update on hiredis-rb ;) |
+1 waiting |
You should use the hiredis that is part of the Microsoft Open-Source Redis version: https://github.com/MSOpenTech/redis |
Based on https://github.com/antirez/hiredis/pull/48 , this is my version of it which cleans up some issues and avoids the requirements for all users of the library to include config.h.