-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapters/libhv #904
Add adapters/libhv #904
Conversation
This PR looks good to me, but I can't find a great deal of information about @bjosv Any thoughts? I don't really see a downside to adding another adapter. If we merge it I'll update the |
I have tested the example and it works fine to build and run, so LGTM! |
ac->ev.addWrite = redisLibhvAddWrite; | ||
ac->ev.delWrite = redisLibhvDelWrite; | ||
ac->ev.cleanup = redisLibhvCleanup; | ||
ac->ev.data = io; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter is not supporting timeouts via ac->ev.scheduleTimer
, but I guess that's ok.
It's only supported by 4 of the 9 current adapters.
Add timeout support to libhv adapter. See: #904
Build steps:
output: