set default SSL verification path #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going through all of our open PRs since I'm putting together a new version soon. I'm inclined to merge this as the feature adds quite a lot of convenience (e.g. to connect to a cloud provider Redis endpoint) without having to do all of the work manually via The only real question I have is whether we need to put this behind a |
|
Merged, thanks! We can bikeshed whether we need to put it behind an option when putting together the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing default verify path for client certificates.
Issue causing connection fail if certificate is not specified in connection settings (it's optional so it doesn't need to be specified).
Fixes #927 however issue is not skipping verification but setting default path.