Move package util into jedis

[sazzad16]

In util package:

• Some classes contain the name Jedis
• Some classes are dependant on elements in package jedis (e.g. exceptions)

IMHO, both of these should be avoided. A simple solution for this is to move entire util into jedis.

[HeartSaVioR]

LGTM. Nice improvements.

[HeartSaVioR]

Since it is clear backward incompatibility, I'd like to have @marcosnils also taking a look.

[sazzad16]

@marcosnils ?

[sazzad16]

@marcosnils PING

[marcosnils]

This is already marked as "READY TO MERGE". LGTM!

…

On Sun, Feb 11, 2018 at 2:40 AM, M Sazzadul Hoque ***@***.***> wrote: @marcosnils <https://github.com/marcosnils> PING — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1689 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABgV2tCAxaKpl2Ej7Bv76jyOH5EKtwdeks5tTn1GgaJpZM4Q0K-q> .

[sazzad16]

@marcosnils I just marked READY TO MERGE after waiting two months for your opinion :)
Wanted to make sure you don't oppose the idea.

[sazzad16]

Merged into master.

[gkorland]

@sazzad16
i think we need to add "proxy" files on the original packages to prevent backward issues
It seems like iא's also effecting the spring-redis-data

You can see that they are using couple of util classes

https://github.com/spring-projects/spring-data-redis/search?q=%22redis.clients.util.%22&unscoped_q=%22redis.clients.util.%22

[gkorland]

org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'redisConnectionFactory' defined in class path resource [org/springframework/boot/autoconfigure/data/redis/JedisConnectionConfiguration.class]: 
Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: 
Failed to instantiate [org.springframework.data.redis.connection.jedis.JedisConnectionFactory]: 
Factory method 'redisConnectionFactory' threw exception; 
nested exception is java.lang.NoClassDefFoundError: **redis/clients/util/SafeEncoder**

[sazzad16]

@gkorland
As long as 2.x is being used, there shouldn't a problem. Besides, I can see spring-data-redis is officially using jedis-2.9.0. They'd also be able to use 2.10.x easily.

However, it requires only 7 changes in 6 files to make spring-data-redis be compatible with jedis-3.x. This should be a simple task. Isn't it? :)