JedisPoolConfig: Helper class for Spring configuration of object pool Config

[sehugg]

No description provided.

[gsharma]

I was just going to make an issue to wrap the Config class in order to fix the ripple effect caused by exposing this to all Jedis clients who now have to add commons-pool dependency just to use the JedisPool. We can use Steven's JedisPoolConfig wrapper to internally populate the commons-pool Config and change JedisPool constructor to use JedisPoolConfig instead. This will also necessitate JedisPoolConfig not extending Config. The basic idea is for Jedis to manage its external library dependencies internally and not leak them via its interfaces to clients (leaky abstractions).

[xetorthio]

This is OK also I need this to set some default to the pool to make it better for Redis.
Thanks a lot and sorry for the delay, was on vacations.

[gsharma]

What I was implying was to remove the commons-pool Config from JedisPool constructor so the dependency does not leak. Actually, a jedis.conf file can have details for commons-pool configuration where all the parameters for Config can be specified and Jedis can internally create the commons-pool Config object instead of clients having to inject it. That way we don't spill Jedis's dependency to its clients.

[xetorthio]

pushed to master with pool defaults as described in this issue https://github.com/xetorthio/jedis/issues#issue/73