-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPE in RedisStateMachine #576
Comments
Looks like the output you choose for your Lua runs into an error. Can you provide a minimal reproducible test case for the first error? |
Regular commands read by PubSub connections are now decoded with the regular CommandHandler decoding. Previously, decoding used an own code path which diverged from what happened in CommandHandler.
Regular commands read by PubSub connections are now decoded with the regular CommandHandler decoding. Previously, decoding used an own code path which diverged from what happened in CommandHandler.
This is my API usage pattern In production I use sentinel configuration, btw. I see you made some commits, can I try as snapshot? |
Sure, you can get the snapshots from oss.sonatype.org, see https://github.com/lettuce-io/lettuce-core#binariesdownload. The changes prevent a NPE caused by a I took a cursory look on your code. There's nothing really wrong with it. You can raise the log level for |
Now I get exceptions much less frequently. And they gone after reconnetion.
|
Another digit
|
I very much sure that issue is caused by |
You're right. The reason is that Lettuce doesn't decode properly You can see somewhat in the logs: Expected:
Actual:
The response is:
I didn't notice the fact that you Thanks for your support to figure out the actual problem. I need to check how/whether a proper |
In fact I am not doing ping on pub-sub connection. I use data connection for ping. |
The posted stack traces show something different. Your log contains |
I invoke ping on |
You might want to debug the code. I don't think there's anything I could do right now. The original NPE is fixed and we have a ticket to address the PING issue. |
It could be that same PubSub connection gets autowired to both places. I will test with qualifiers and activated ping again. |
Yes, it was ping at pub-sub connection. Unintentional, though. Lets close this and keep #579. |
I think this is one is also related to #724. |
Lettuce 3.5.0 is used. |
@ted12 Please don't comment on closed tickets without a clear relation to the actual ticket. Lettuce 3.5 is out of maintenance. Feel free to fork the repository and fix the issue for yourself. |
Hello.
I have a lot of warnings like in my production. Lettuce 4.3.3 is used.
I have one connection for set/get and atomic get and delete using Lua script (not Tx anymore). And another connection is for expiration notificaitons.
However this exception happens completely inside Lettuce.
In RedisStateMachine.java:115 null is passed intentionally and then NPE happens.
return decode(buffer, null, output);
Another issue is
I am not sure if they are related or not.
The text was updated successfully, but these errors were encountered: