Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synchronized keywords #57 #59

Merged
merged 2 commits into from
May 9, 2015
Merged

Remove synchronized keywords #57 #59

merged 2 commits into from
May 9, 2015

Conversation

mp911de
Copy link
Collaborator

@mp911de mp911de commented May 5, 2015

Remove synchronization on dispatch methods in order to prevent deadlocks. CommandHandler holds a reentrant lock which allows to get a lock within the same thread on reconnecting. Clients issuing a command during connection activation will wait until the connection is activated.

Remove synchronization on dispatch methods in order to prevent deadlocks. CommandHandler holds a reentrant lock which allows to get a lock within the same thread on reconnecting. Clients issuing a command during connection activation will wait until the connection is activated.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.15%) to 95.15% when pulling 2a78a3e on issue-57-deadlock into 877ab03 on master.

mp911de added a commit that referenced this pull request May 9, 2015
@mp911de mp911de merged commit 93de688 into master May 9, 2015
@mp911de mp911de deleted the issue-57-deadlock branch May 19, 2015 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants