Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ZINTERCARD and SINTERCARD #2040

Merged
merged 3 commits into from
Mar 20, 2022
Merged

Support ZINTERCARD and SINTERCARD #2040

merged 3 commits into from
Mar 20, 2022

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine commented Mar 16, 2022

Description

Two new commands:

  1. SINTERCARD
  2. ZINTERCARD

Closes #1977, Closes #1971


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #2040 (87ff90f) into master (be51abe) will decrease coverage by 0.20%.
The diff coverage is 55.55%.

❗ Current head 87ff90f differs from pull request most recent head dda6cf6. Consider uploading reports for the commit dda6cf6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   94.83%   94.62%   -0.21%     
==========================================
  Files         360      362       +2     
  Lines        3366     3384      +18     
  Branches      411      413       +2     
==========================================
+ Hits         3192     3202      +10     
- Misses         89       97       +8     
  Partials       85       85              
Impacted Files Coverage Δ
packages/client/lib/commands/SINTERCARD.ts 50.00% <50.00%> (ø)
packages/client/lib/commands/ZINTERCARD.ts 50.00% <50.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be51abe...dda6cf6. Read the comment docs.

@leibale leibale merged commit 875298e into master Mar 20, 2022
@leibale leibale deleted the Z/S_INTERCARD branch March 20, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redis command: ZINTERCARD (R7) Add support for redis command: SINTERCARD (R7)
3 participants