Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis.io website examples #2474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Redis.io website examples #2474

wants to merge 2 commits into from

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Apr 17, 2023

Description

Add a separate folder and define the process of adding examples for redis.io


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@uglide uglide changed the title Emb examples Redis.io website examples Apr 17, 2023
@uglide uglide requested review from chayim and leibale April 17, 2023 15:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (d65a641) 95.63% compared to head (3946702) 95.67%.

❗ Current head 3946702 differs from pull request most recent head aca8b30. Consider uploading reports for the commit aca8b30 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   95.63%   95.67%   +0.03%     
==========================================
  Files         455      455              
  Lines        4579     4552      -27     
  Branches      528      522       -6     
==========================================
- Hits         4379     4355      -24     
+ Misses        129      128       -1     
+ Partials       71       69       -2     
Impacted Files Coverage Δ
packages/client/lib/client/pub-sub.ts 79.85% <ø> (ø)
packages/client/lib/commander.ts 95.45% <ø> (ø)
packages/client/lib/client/index.ts 93.20% <100.00%> (+0.87%) ⬆️
packages/client/lib/client/socket.ts 82.94% <100.00%> (+0.77%) ⬆️
packages/client/lib/cluster/index.ts 81.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Add set & get example
- Use bash script to test doc tests
- Add package.json to doctests
- Add search-quickstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants