Fix auth callback being called more than once #848
Conversation
|
It won't I am afraid, sorry. You have to synchronise the change in the application with the change in redis itself which is not really possible without failing some commands. The approach I had in mind is to try re-authenticating when some command fails. I've actually implemented both parts of #821 (enabling and changing the password in redis) in PR #831. I see you're overloaded with them, so easy to miss, I understand... What the change does is completely transparent for the application, it doesn't have to call any methods to change password, and not a single command is lost. The driver re-authenticates using a supplied password in case some command fails because of authentication and then re-issues the same command to redis - and the original callback is called with the result of the re-issued command. There are tests as well. I also tried to explain in readme how it works. |
BridgeAR
changed the title
The arguments parameter was faulty andthe callback could have been triggered twice
Fix auth callback being called more than once
@epoberezkin I guess this would solve #821 or did I miss something? I was not sure if I understood correct what you wanted to do, so I created these two tests.