Bugfix for culture invariant decimal types #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @axnetg - can you do one more merge with main - seems I don't have permission to push to your branch :). Should fix the build issues. |
slorello89
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Hey @axnetg - yeah sorry there was a breaking change in 0.6.0 (basically the core Execute method now accepts an array of objects rather than an array of strings, so all these setup bits need to be updated.
test/Redis.OM.Unit.Tests/RediSearchTests/AggregationSetTests.cs
Outdated
Show resolved
Hide resolved
test/Redis.OM.Unit.Tests/RediSearchTests/AggregationSetTests.cs
Outdated
Show resolved
Hide resolved
slorello89
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418.
This PR solves an issue related to serialization of decimal types (float, double, and decimal) in cultures where the dot is not the decimal number separator, causing updates and some queries to behave inconsistently. I also noticed that aggregations were also affected by this problem, so this fixes that as well.