Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper python 3.11 support #446

Merged
merged 4 commits into from
Dec 28, 2022
Merged

fix: proper python 3.11 support #446

merged 4 commits into from
Dec 28, 2022

Conversation

YaraslauZhylko
Copy link
Contributor

@YaraslauZhylko YaraslauZhylko commented Dec 23, 2022 •
edited
Loading

Description

Properly support Python 3.11 versions.

Related issues

@YaraslauZhylko YaraslauZhylko mentioned this pull request Dec 23, 2022
Closed
@YaraslauZhylko YaraslauZhylko marked this pull request as ready for review December 23, 2022 21:18
@YaraslauZhylko YaraslauZhylko changed the title fix: propper python 3.11 support fix: proper python 3.11 support Dec 23, 2022
XChikuX
XChikuX suggested changes Dec 24, 2022
View reviewed changes
Copy link

@XChikuX XChikuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the changes suggested

pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
XChikuX
XChikuX previously approved these changes Dec 25, 2022
View reviewed changes
Copy link

@XChikuX XChikuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Redis-om maintainers please double check and approve!

dvora-h
dvora-h previously approved these changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022 •
edited
Loading

Codecov Report

Base: 78.87% // Head: 78.85% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (946d9c5) compared to base (1e33e25).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   78.87%   78.85%   -0.02%     
==========================================
  Files          14       14              
  Lines        1174     1173       -1     
==========================================
- Hits          926      925       -1     
  Misses        248      248
Flag Coverage Δ
unit 78.85% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aredis_om/model/model.py 87.02% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YaraslauZhylko
Copy link
Contributor Author

Am I supposed to fix the dependency vulnerability as well?
https://github.com/redis/redis-om-python/actions/runs/3770460277/jobs/6418717485#step:5:111

Or should it be done in a separate PR?

@YaraslauZhylko
Copy link
Contributor Author

I guess, the vulnerability is not fixable at the moment as gitpython==3.1.29 is the latest available version of the package and no fix has been released yet.

So "admin merge" of this PR may be an option to move forward.

@dvora-h dvora-h dismissed stale reviews from XChikuX and themself via 946d9c5 December 27, 2022 12:49
@YaraslauZhylko
Copy link
Contributor Author

YaraslauZhylko commented Dec 27, 2022 •
edited
Loading

With the vulnerability ignored, all jobs now pass successfully.

Still need a re-approval, as the previous ones got automatically (?) dismissed.

@dvora-h dvora-h merged commit 7bc8b40 into redis:main Dec 28, 2022
@YaraslauZhylko YaraslauZhylko deleted the fix/proper-python-3.11-support branch December 28, 2022 09:09
@YaraslauZhylko YaraslauZhylko mentioned this pull request Jan 5, 2023
Closed
chayim pushed a commit that referenced this pull request Jan 8, 2023
@YaraslauZhylko @dvora-h @chayim
fix: proper python 3.11 support (#446)
12fe221 
* fix: propper python 3.11 support

* fix tox config

* wider python 3.x support

* Update ci.yml

Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
dvora-h added a commit that referenced this pull request Jan 8, 2023
@chayim @YaraslauZhylko @dvora-h
Updating documentation to use redis.asyncio (#447)
6955225 
* removing aioredis from documentation

* fix: proper python 3.11 support (#446)

* fix: propper python 3.11 support

* fix tox config

* wider python 3.x support

* Update ci.yml

Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

* Add poetry.lock to .gitignore (#457)

* Add poetry.lock to .gitignore

* remove poetry.lock

* PR comments readme update

Co-authored-by: Yaraslau Zhylko <YaraslauZhylko@gmail.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XChikuX XChikuX XChikuX left review comments

@dvora-h dvora-h dvora-h approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper Python 3.11 support
4 participants
@YaraslauZhylko @codecov-commenter @XChikuX @dvora-h