-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.2.0 introduces breaking name changes #2061
Comments
Ran into this issue as well. |
I also ran into this issue. This broke a lot of code. It should have been communicated better. |
Additionally, these changes are not reflected in the documentation for the examples of using the client for ReJSON found here. |
Apologies. I must've glossed over the the public methods on the initial grep somehow. I agree that there's nothing we can really do except update the release notes and changelog. If a suggestion popped up for adding compatibility by doing something like |
IMHO redis-py 5 should be released with various breaking changes. I'd like to start planning that after we start profiling, and looking at reasonable improvement. I am so sorry that we broke things. I admit to being embarrassed - we try to never break anything - at least if it's not a major - or intentional. Plan of action we can agree on:
Is there anything else that would be particularly useful? I'd like to make sure we do right by the community. |
This issue is marked stale. It will be closed in 30 days if it is not updated. |
Thanks for wanting to report an issue you've found in redis-py. Please delete this text and fill in the template below.
It is of course not always possible to reduce your code to a small test case, but it's highly appreciated to have as much data as possible. Thank you!
Version: What redis-py and what redis version is the issue happening on?
4.2.0
Platform: What platform / version? (For example Python 3.5.1 on Windows 7 / Ubuntu 15.10 / Azure)
Linux
Description: Description of your issue, stack traces from errors and code that reproduces the issue
E AttributeError: type object 'Path' has no attribute 'rootPath'
Updating to 4.2.0 breaks access to the items that were renamed by the fix for #1864
This was a breaking change that needed to have documentation in the release notes and preferably a major release update.
I'm not sure what can be done about it now other than updating the 4.2.0 release notes to document the change.
The text was updated successfully, but these errors were encountered: