potential bugs in _send_command and _read

[awestendorf]

I was browsing the driver source in the course of reviewing Redis for work and found a few potential bugs in the socket code.

The _read() method is calling "return self._fp.readline()", but this is bypassing the code at the end of the method which should be checking to see if self._sock.recv()=='', so a disconnect will likely not be handled correctly. It seems that _get_response() might handle this correctly, but _get_value() will raise a ValueError instead of a ConnectionError.

In the _send_command() method, if an EPIPE is raised, it won't work across platforms because it's checking if the value is 32, and not errno.EPIPE. I've had trouble with this in the past, as Linux and OSX use different enumerations.

[andymccurdy]

Thanks for finding this issue. It has been resolved in the "newapi" branch of redis-py. I plan on merging it into master in the next day or two, and then making an official release.

[andymccurdy]

This issue has been resolved in the 1.34 release of redis-py.

[awestendorf]

Glad I could help. I was going to patch it in a branch but ran out of time. We're very interested in redis and will be using this driver when we get around to experimenting with it.