Support BIT/BYTE for bitcount and bitpos for redis 7+
#1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about: |
fatkodima
force-pushed
the
bitcount-bitpos-add-bits-unit
branch
from
9c6af45
to
d04583b
Compare
|
👍 for |
fatkodima
force-pushed
the
bitcount-bitpos-add-bits-unit
branch
from
d04583b
to
2d0bc45
Compare
byroot
reviewed
Dec 9, 2023
lib/redis/commands/bitmaps.rb
Outdated
| send_command([:bitcount, key, start, stop]) | ||
| def bitcount(key, start = 0, stop = -1, scale: 'BYTE') | ||
| command = [:bitcount, key, start, stop] | ||
| command << 'BIT' if scale.to_s.upcase == 'BIT' |
There was a problem hiding this comment.
Suggested change
| command << 'BIT' if scale.to_s.upcase == 'BIT' | |
| command << 'BIT' if scale. |
I think we should append it unless it's not set. Because here if I pass scale: "lol", it will silently do nothing.
With scale: nil in the signature.
fatkodima
force-pushed
the
bitcount-bitpos-add-bits-unit
branch
from
2d0bc45
to
9a6abb4
Compare
byroot
reviewed
Dec 9, 2023
lib/redis/commands/bitmaps.rb
Outdated
| @@ -27,9 +27,13 @@ def getbit(key, offset) | |||
| # @param [String] key | |||
| # @param [Integer] start start index | |||
| # @param [Integer] stop stop index | |||
| # @param [String, Symbol] scale the scale of the offset range | |||
| # e.g. 'BYTE' - interpreted as a range of bytes, 'BIT' - interpreted as a range of bites | |||
There was a problem hiding this comment.
Suggested change
| # e.g. 'BYTE' - interpreted as a range of bytes, 'BIT' - interpreted as a range of bites | |
| # e.g. 'BYTE' - interpreted as a range of bytes, 'BIT' - interpreted as a range of bits |
byroot
reviewed
Dec 9, 2023
lib/redis/commands/bitmaps.rb
Outdated
| send_command([:bitcount, key, start, stop]) | ||
| def bitcount(key, start = 0, stop = -1, scale: nil) | ||
| command = [:bitcount, key, start, stop] | ||
| command << scale.to_s.upcase if scale |
There was a problem hiding this comment.
I wouldn't even bother with the to_s.upcase, we can directly pass it to redis in lower case, it's no problem.
fatkodima
force-pushed
the
bitcount-bitpos-add-bits-unit
branch
from
9a6abb4
to
df08cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #1187
Redis 7.0 release notes - https://raw.githubusercontent.com/redis/redis/7.0/00-RELEASENOTES
I am not very happy with the
bytes_rangeparameter name. Maybe you can suggest something better? Maybeuse_bytesoroffset_unitetc...