Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EXPIRETIME #1248

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add EXPIRETIME #1248

merged 1 commit into from
Jan 30, 2024

Conversation

wholien
Copy link
Contributor

@wholien wholien commented Jan 30, 2024 •
edited
Loading

@byroot
Copy link
Collaborator

byroot commented Jan 30, 2024

Rubocop is angry, other than that LGTM.

Also maybe you could add PEXPIRETIME too, but no big deal. I'll merge once rubocop is happy (single commit please)

@wholien
Add Expiretime
2e693be 
make rubocop happy is my only desire
@byroot byroot merged commit a51d50c into redis:master Jan 30, 2024
15 of 17 checks passed
@byroot
Copy link
Collaborator

byroot commented Jan 30, 2024

Thanks.

@wholien wholien deleted the jc/add-expiretime branch January 30, 2024 09:54
@wholien
Copy link
Contributor Author

wholien commented Jan 30, 2024

Also maybe you could add PEXPIRETIME too, but no big deal. I'll merge once rubocop is happy (single commit please)

i will do that! sorry, didn't see this

@wholien
Copy link
Contributor Author

wholien commented Jan 30, 2024

Rubocop is angry, other than that LGTM.

Also maybe you could add PEXPIRETIME too, but no big deal. I'll merge once rubocop is happy (single commit please)

added here #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wholien @byroot