-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enable read operation #598
Conversation
Hi @proost, The docker used in Github Actions seems to be updated and the |
rueidisprob/bloomfilter.go
Outdated
return nil, err | ||
} | ||
|
||
if parseRedisMajorVersion(info) < 7 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users may run a redis cluster with mixed versions and a single INFO request is not enough for checking the version of each node. Actually, I think this check is unnecessary. Stating the version requirement in the comment of WithEnableReadOperation is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users may run a redis cluster with mixed versions and a single INFO request is not enough for checking the version of each node.
Oh, i missed. thank you.
Merged. But I forgot that the |
Discussion
As we discussed before, supporting replica when using bloom filter.