Fix rueidislock highload #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rueian <rueiancsie@gmail.com>
Signed-off-by: Rueian <rueiancsie@gmail.com>
rueian
force-pushed
the
fix-rueidislock-highload
branch
2 times, most recently
from
5acf6b9
to
0db70e2
Compare
Signed-off-by: Rueian <rueiancsie@gmail.com>
rueian
force-pushed
the
fix-rueidislock-highload
branch
from
0db70e2
to
bdd1bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #602
This PR keeps using the same event watcher of client-side caching during the retries of
rueidislock.WithContextand watches the event for retrying.Previously, there was a race that could lead to the removal of the watcher thus causing busy retries and missing events.