Skip to content

[2.10] [MOD-8125] Create inverted index in write operations only #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2024
Merged

[2.10] [MOD-8125] Create inverted index in write operations only #5257

merged 2 commits into from
Nov 26, 2024

Conversation

meiravgri
Copy link
Collaborator

backport #5229 to 2.10

mainly conflicts with #5216

@meiravgri
[MOD-8125] Create inverted index in write operations only (#5229)
abf0ddf 
* open vector for read

* don't create vector index  in read mode

* use  OPEN_INDEX_READ or OPEN_INDEX_WRITE in tags

* remove unused openindex function

* create vecsim index to capture info in debug commands

add create_if_missing variable to OpenGeometryIndex

 dont create text index in gc if doesn't exist

* use DONT_CREATE_INDEX in NewVectorIterator

* introduce FT.DEBUG SPEC_INVIDXES_INFO INDEX_NAME

introduce test_index to test lazy intialziation

* fix

* cosmetics

* skip testSpecIndexesInfo in coord

* rename openVectorKeysDict to openVectorIndex

add depth arg to pytest callbacks

add test_lazy_index_creation_info_modules

some tests improvments

* fix field name in test

* pass

(cherry picked from commit 7617563)
@meiravgri meiravgri changed the title [2.10] [MOD-8125] Create inverted index in write operations only (#5229) [2.10] [MOD-8125] Create inverted index in write operations only Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (a1f460e) to head (9576231).
Report is 1 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/fork_gc.c 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.10    #5257      +/-   ##
==========================================
+ Coverage   86.46%   86.55%   +0.09%     
==========================================
  Files         192      192              
  Lines       34129    34142      +13     
==========================================
+ Hits        29509    29552      +43     
+ Misses       4620     4590      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiravgri meiravgri requested a review from alonre24 November 26, 2024 09:32
@meiravgri meiravgri added this pull request to the merge queue Nov 26, 2024
Merged via the queue into 2.10 with commit 555557c Nov 26, 2024
10 checks passed
@meiravgri meiravgri deleted the backport-5229-to-2.10 branch November 26, 2024 10:18
raz-mon added a commit that referenced this pull request Jan 30, 2025
@raz-mon
Revert "[2.10] Fix Max Frequency Misscalculation - [MOD-8158] (#5557)"
337a625 
This reverts commit a97e925.

Revert "[2.10] MOD-8601: Fix error message for LOAD (#5531) (#5550)"

This reverts commit 5748233.

Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

Revert "[2.10] Fix legacy geofilter leak - [MOD-8568] (#5516)"

This reverts commit 8b75285.

Revert "[2.10] MOD-7872: Add Types To Hide User Input (#5485)"

This reverts commit d6acfed.

Revert "[2.10] MOD-7864: Obfuscation API (#5487)"

This reverts commit 259d417.

Revert "MOD-7570 Backport 5422 to 2.10 (#5472)"

This reverts commit e699dbc.

Revert "[2.10] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5446)"

This reverts commit a90cfc3.

Revert "[2.10] MOD-8058: Avoid error with _NUM_SSTRING (#5424)"

This reverts commit 885cffb.

Revert "[2.10] MOD-7634: Fix NOSTEM (#5392)"

This reverts commit 4df508d.

Revert "[2.10] Fixes for inverted indexes encoding - [MOD-8248] (#5388)"

This reverts commit bc003c1.

Revert "[2.10] Improve "Raw doc id" encoding - [MOD-8255] (#5372)"

This reverts commit 9789e30.

Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

Revert "[2.10] Improve counting active writes - [MOD-8151] (#5362)"

This reverts commit a3d447d.

Revert "[2.10] [MOD-8039] Reorganize stats files (#5356)"

This reverts commit a1b8b29.

Revert "[2.10] Improve text indexing performance - [MOD-8249] (#5352)"

This reverts commit c5c9245.

Revert "[2.10] [MOD-8115] Free spec resources in the main thread (#5327)"

This reverts commit 42bb520.

Revert "[2.10] Sorting Vector - [MOD-6783] (#5314)"

This reverts commit 166a00e.

Revert "[2.10] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5300)"

This reverts commit 5c4ed74.

Revert "[2.10] Remove assertion in optimizer (#5292)"

This reverts commit ba55efb.

Revert "[2.10] Fix missing expansions in text queries - [MOD-8142] (#5284)"
This reverts commit 10f32d3.

Revert "[2.10] Fix Tag OnReopen Callback - [MOD-8011] (#5282)"

This reverts commit 2c029ee.

Revert "[2.10] Fix MRIterator ownership mechanism - [MOD-8108] (#5266)"

This reverts commit 457536e.

Revert "[2.10] [MOD-8125] Create inverted index in write operations only (#5257)"

This reverts commit 555557c.

Revert "[2.10] [MOD-8152] rename and move new metrics (#5255)"

This reverts commit a1f460e.

Revert "[2.10] MOD-8129: Fix indexed_percent info stat (#5247)"

This reverts commit d55afb5.

Revert "[2.10] MOD-8097, MOD-8114 Fix memory counting (#5204) (#5241)"

This reverts commit 52e58af.

Revert "[MOD-7949] Avoid lazy expire upon scan keys in background [2.10] (#5294)"

This reverts commit 6dfb503.

Revert "[2.10] Cleanup for the trimming tree logic (#5226)"

This reverts commit 7dfe6a2.

Revert "[2.10] Add global marked deleted to stats [MOD-6053] (#5208)"

This reverts commit f396732.

Revert "Fix and add skips in pytest (#5210)"

This reverts commit a8b505c.

Revert "[2.10] [MOD-8035] Add field index error for JSON field indexing failures (#5202)"

This reverts commit ed1919e.

Revert "[2.10] Improve usage of RedisModuleCtx (#5181)"

This reverts commit 8e686c7.

Revert "[2.10] Add Active Indices Metrics - [MOD-7952] (#5179)"

This reverts commit b72fc38.

Revert "[2.10] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5166)"

This reverts commit 92e1dd8.

Revert "[2.10] Send `SCORER` to the shards with `FT.AGGREGATE` on cluster mode - [MOD-8060] (#5163)"

This reverts commit 4982ea2.

Revert "[2.10] [MOD-8034] expose indexing failures to INFO modules (#5158)"

This reverts commit d03f8de.

Revert "[2.10] Add a counter of total query execution time - [MOD-7961] (#5153)"

This reverts commit d45365d.

Revert "[2.10] Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5146)"

This reverts commit 094318f.

Revert "[2.10] Remove an unnecessary assertion - [MOD-8008] (#5142)"

This reverts commit 3156f08.

Revert "[2.10] Skip test_multithread:test_async_updates_sanity with sanitizer  (#5125)"

This reverts commit 5339033.

Revert "Count Queries - [MOD-6492] (#5072)"

This reverts commit 1006065.

Revert "[2.10] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5109)"

This reverts commit 9621fdc.

Revert "[2.10] Fix flaky test (#5086)"

This reverts commit 5aff118.

Revert "[2.10] Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5081)"

This reverts commit 2b85289.

Revert "[2.10] MOD-7745: Add Benchmarks For Document And Field Expiration (#5063)"

This reverts commit f99b0cf.

Revert "[2.10] MOD-7863: Add HPEXPIRETIME Mock Support (#5028)"

This reverts commit 79dfd0f.
@raz-mon raz-mon mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonre24 alonre24 alonre24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meiravgri @alonre24