[2.10] MOD-7944: Support multi-byte char terms (#5391) #5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 43701d8)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5646 +/- ##
==========================================
+ Coverage 87.48% 87.51% +0.03%
==========================================
Files 196 196
Lines 34157 34229 +72
==========================================
+ Hits 29883 29957 +74
+ Misses 4274 4272 -2 ☔ View full report in Codecov by Sentry. |
raz-mon
approved these changes
Feb 17, 2025
Comment on lines
+1
to
+6
| /* | ||
| * Copyright Redis Ltd. 2016 - present | ||
| * Licensed under your choice of the Redis Source Available License 2.0 (RSALv2) or | ||
| * the Server Side Public License v1 (SSPLv1). | ||
| */ | ||
|
|
There was a problem hiding this comment.
This has got to stop happening.. 🤦♂️
oshadmi
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #5391 to
2.10.(cherry picked from commit 43701d8)
Since Version 2.10 limits the normalization buffer to 128 bytes,
#define MAX_NORMALIZE_SIZE 128, expected results intestLongTerms()were modified to respect that limitation.In
testMultibyteTag, for tests using DIALECT 4, the number of results was changed to ANY, because in this version a wrong count is returned.In test_cpp_llapi.cpp,
RediSearch_CreateTagLexRangeNode()receives only 5 arguments, in this versionconst char* fieldNameis not part of the function signature